Skip to content

feat: custom CustomPickups return value#135

Merged
Zamiell merged 6 commits intoIsaacScript:mainfrom
KOSMOGOR:main
Feb 25, 2026
Merged

feat: custom CustomPickups return value#135
Zamiell merged 6 commits intoIsaacScript:mainfrom
KOSMOGOR:main

Conversation

@KOSMOGOR
Copy link
Contributor

…tionality

fix: getAdjustedPrice() now uses Math.ceil() instead of Math.floor()
fix: changed version using "npm audit fix"

…tionality

fix: getAdjustedPrice() now uses Math.ceil() instead of Math.floor()
fix: changed version using "npm audit fix"
@Zamiell
Copy link
Member

Zamiell commented Feb 24, 2026

is there a particular reason why are you removing this: void from the callback functions?
also, remove your changes from the lock file, we should only be updating that when the actual dependencies change, right?

@KOSMOGOR
Copy link
Contributor Author

I thought this: void was useless in signatures... I will revert it, as well as lock file

revert: package-lock.json
@Zamiell
Copy link
Member

Zamiell commented Feb 24, 2026

it has meaning in TSTL.
read: https://typescripttolua.github.io/docs/the-self-parameter/#this-void

@KOSMOGOR
Copy link
Contributor Author

got it, thank you

@Zamiell Zamiell changed the title update: changed signature of functions in CustomPickups for more func… feat: custom CustomPickups return value Feb 25, 2026
Co-authored-by: James <5511220+Zamiell@users.noreply.github.com>
@Zamiell Zamiell merged commit 736ba9f into IsaacScript:main Feb 25, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants